Improve CameraControl touch dolly/pan #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeolabs
changed the title
|
@Amoki thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But when doing a zoom, a pick is done at each tick, and the pick costs ~60% of the time (cf. flame graph).
Checking the distance only once when the two fingers are touching the screen and keeping it until a finger leaves the screen seems a good UX and is more performant.
cameraUpdater doesn't pick anything itself anymore, each handler must explicitly pick before a dolly.
Touch events were triggered for every pixel, implying 150 updates of 1 pixel instead of 1 update of 150px. This led to very slow dolly.
I retored my
viewer.cameraControl.touchDollyRate = 0.2;to avoid too fast dolly.Pan and dolly can also be done simultaneously: it's way more smooth and a better UX overall.