Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring change in props (format / duration / etc.) #23

Closed
kfiroo opened this issue Jul 18, 2016 · 3 comments
Closed

Ignoring change in props (format / duration / etc.) #23

kfiroo opened this issue Jul 18, 2016 · 3 comments

Comments

@kfiroo
Copy link

kfiroo commented Jul 18, 2016

@xgfe Hey,
First of all thanks for writing this cool Date Picker :)

Looks like in the constructor you assign some props to instance variables that you later use in your code, that causes changes in these props to be ignored by code that runs after the change.

Any chance you could fix that?

Thanks,
kfir

@kfiroo
Copy link
Author

kfiroo commented Jul 18, 2016

@feyy
Copy link
Contributor

feyy commented Jul 19, 2016

Thanks for your propose. It's really a terrible implement. Will fix in the next release.

@kfiroo
Copy link
Author

kfiroo commented Jul 19, 2016

@feyy Cool! Let me know if I can help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants