Made exact assortativity reproducible #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #526 +/- ##
==========================================
- Coverage 92.20% 92.19% -0.02%
==========================================
Files 60 60
Lines 4389 4392 +3
==========================================
+ Hits 4047 4049 +2
- Misses 342 343 +1 ☔ View full report in Codecov by Sentry. |
|
@thomasrobiglio, do you think you will be able to review this PR? Thanks! |
|
hey @nwlandry, sure! I will review this afternoon or tomorrow morning :) |
|
Thanks so much! I appreciate it! |
thomasrobiglio
approved these changes
Apr 2, 2024
|
Thanks so much for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the$(u, v)$ and $(v,u )$ (See this comment). This PR fixes this issue.
degree_assortativityfunction, when using theexactkeyword, it was not reproducible because the two degrees were randomly shuffled prior to putting into thenumpy.corrcoeffunction. NetworkX handles this by copying the pairs twice: