-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the ability for XGI to load data collections #540
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #540 +/- ##
==========================================
+ Coverage 92.35% 92.41% +0.05%
==========================================
Files 60 60
Lines 4500 4548 +48
==========================================
+ Hits 4156 4203 +47
- Misses 344 345 +1 ☔ View full report in Codecov by Sentry. |
Idea sounds nice! Can you elaborate a bit, what do you mean by collection and what's your intended workflow with this? |
So my original intent was to figure out how to store collections similar to this one. I opened Issue 20 in XGI-DATA for this issue. The choices in my mind were (1) make a huge file containing all the hypergraphs or (2) continue to have a file for each hypergraph, but in addition have a collection file specifying metadata of the collection as well as where to find each dataset in the collection. There might be a more elegant way, but this is the best I've come up with so far. Note that with this PR, you can call |
Just to check, in the end you chose option (2) right? And this is implemented as a single record in Zenodo for the collection containing many .json files (one for each dataset).
This is very nice and good for now thanks Nich. As I mentioned in our call, I'm wondering if don't want to be able to access them directly from something like Btw, related to #548 I don't think the loading function is in the online docs. |
Thanks for the review! I completely agree, but this will take a bit longer to figure out how to implement. Let me know if you'd rather I wait to implement accessing/viewing individual datasets to merge or if I should open an issue on this. What do you mean when you say that the loading function isn't in the online docs? |
Yes I think we can just open an issue about this!
I mean that |
Thanks!! I added two issues from your comments. |
Refactored the following to handle collections of data:
load_xgi_data
download_xgi_data
write_json
read_json
Also did the following:
write_json
toto_hypergraph_dict
dict_to_hypergraph
tofrom_hypergraph_dict