Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement add_node_to_edge and remove_node_from_edge for DiHypergraphs #571

Merged
merged 8 commits into from
Aug 23, 2024

Conversation

nwlandry
Copy link
Collaborator

@nwlandry nwlandry commented Aug 8, 2024

This adds the ability to add/remove nodes to/from a directed hyperedge.

@nwlandry nwlandry requested a review from maximelucas August 8, 2024 22:27
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.51%. Comparing base (d7a90a7) to head (7898eaa).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #571   +/-   ##
=======================================
  Coverage   92.51%   92.51%           
=======================================
  Files          59       59           
  Lines        4393     4394    +1     
=======================================
+ Hits         4064     4065    +1     
  Misses        329      329           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nwlandry
Copy link
Collaborator Author

@maximelucas are you still able to review this?

@nwlandry
Copy link
Collaborator Author

In the interest of time, and since all modified lines are covered by tests, I am merging this.

@nwlandry nwlandry merged commit 7646f9d into main Aug 23, 2024
23 checks passed
@nwlandry nwlandry deleted the directed-add-node-to-edge branch August 23, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant