Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from setup.py to pyproject.toml #573

Merged
merged 32 commits into from
Aug 28, 2024
Merged

Switch from setup.py to pyproject.toml #573

merged 32 commits into from
Aug 28, 2024

Conversation

nwlandry
Copy link
Collaborator

According to PEP 621, projects are encouraged to migrate to a pyproject.toml file.

Copy link

codecov bot commented Aug 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.14%. Comparing base (3252b7f) to head (633e8a1).
Report is 58 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #573   +/-   ##
=======================================
  Coverage   93.14%   93.14%           
=======================================
  Files          60       60           
  Lines        4495     4495           
=======================================
  Hits         4187     4187           
  Misses        308      308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nwlandry nwlandry linked an issue Aug 26, 2024 that may be closed by this pull request
@nwlandry nwlandry requested a review from maximelucas August 26, 2024 20:15
README.md Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@maximelucas
Copy link
Collaborator

maximelucas commented Aug 27, 2024

Thanks a lot Nich! Looks good. Just a few questions above.

(Edit: whoops, accidentally closed, then reopened)

@maximelucas maximelucas reopened this Aug 27, 2024
@nwlandry
Copy link
Collaborator Author

@maximelucas Should have addressed all of your comments, thanks!

@maximelucas
Copy link
Collaborator

Amazing, thanks so much!
Last tiny question but approving already.

@nwlandry nwlandry merged commit 9492352 into main Aug 28, 2024
24 checks passed
@nwlandry nwlandry deleted the pyproject-toml branch August 28, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change setup.py to pyproject.toml
2 participants