fix #580 + related test #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Thomas! I think I would move the logic of this to What do you think? |
|
Yes, makes more sense the way you say, on it. |
maximelucas
reviewed
Sep 7, 2024
maximelucas
reviewed
Sep 7, 2024
maximelucas
reviewed
Sep 7, 2024
xgi/core/simplicialcomplex.py
Outdated
| supfaces_ids = self._supfaces_id(self._edge[id]) | ||
| for sup_id in supfaces_ids: | ||
| self._remove_simplex_id(sup_id) | ||
| self.remove_simplex_id(sup_id) |
There was a problem hiding this comment.
I don't this was wrong before so I wouldn't touch it, unless you think it's more efficient?
There was a problem hiding this comment.
good catch, thx
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
maximelucas
approved these changes
Sep 9, 2024
thomasrobiglio
added a commit
to thomasrobiglio/xgi
that referenced
this pull request
Sep 9, 2024
thomasrobiglio
added a commit
that referenced
this pull request
Sep 12, 2024
* feat: function + test * style: formatted with black * fix: iteration over orders * fix: removed iteration across orders * test: added test for k=0, related to #581 * style: black * docs: added explanation + link to ref * docs: rephrased definition * moved function to `convert.simplex` + created file for test * added k_skeleton to api rst file * use `max_edge_order` function * created cut_to_order + modified k_skeleton + tests * added cut_to_order to api * style: black * minor change for consistency with other functions * modified recipe * changed formatting in the recipe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #580