Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website edits #582

Merged
merged 11 commits into from
Sep 7, 2024
Merged

Website edits #582

merged 11 commits into from
Sep 7, 2024

Conversation

nwlandry
Copy link
Collaborator

@nwlandry nwlandry commented Sep 6, 2024

This PR

  • Fixes the color switching issues
  • Removes unnecessary files
  • Fixes sphinx errors from the migration to the PyData theme
  • Fixes Fix See Also links #341

@nwlandry nwlandry requested a review from maximelucas September 6, 2024 18:29
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.13%. Comparing base (19b6171) to head (2858ae1).
Report is 55 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #582   +/-   ##
=======================================
  Coverage   93.13%   93.13%           
=======================================
  Files          60       60           
  Lines        4503     4503           
=======================================
  Hits         4194     4194           
  Misses        309      309           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maximelucas
Copy link
Collaborator

Nice work Nich! Just a few questions. I like the color switch and that you added the case studies back in.

@nwlandry
Copy link
Collaborator Author

nwlandry commented Sep 7, 2024

Nice work Nich! Just a few questions. I like the color switch and that you added the case studies back in.

Thanks so much for the review! I believe I addressed all your comments.

@nwlandry nwlandry merged commit bc9a30b into main Sep 7, 2024
24 checks passed
@nwlandry nwlandry deleted the website-edits branch September 7, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix See Also links
2 participants