-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added simpliciality measures #587
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #587 +/- ##
==========================================
+ Coverage 93.13% 93.24% +0.10%
==========================================
Files 60 62 +2
Lines 4503 4679 +176
==========================================
+ Hits 4194 4363 +169
- Misses 309 316 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall and tests appear to pass. Worth considering how we structure the return of the functions, since using exception handling rather than conditionals is a design choice. One function appears to be duplicated. Otherwise good to go!
Thanks for the review, @tlarock! Someone pointed out a minor error in my simpliciality paper, so I'm determining what to do with that first before making your suggested changes. |
Hi @tlarock --- I believe I addressed all of your comments. The URL checker fails, but this was addressed in another PR so it will go away once we merge into the main branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very close! Sorry to be a pain about the documentation, but hopefully easier to clairfy now than later :) Of course feel free to take or leave
@tlarock --- I believe I addressed your comments! I added more extensive documentation in the |
Looks great @nwlandry! Ready for merging on my end. |
This PR adds all the functionality from this repo.