Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random hypergraph #597

Merged
merged 51 commits into from
Oct 16, 2024
Merged

Fix random hypergraph #597

merged 51 commits into from
Oct 16, 2024

Conversation

nwlandry
Copy link
Collaborator

This fixes #361.

Before I fix the tests, is this what you were picturing @maximelucas and @arashbm?

@maximelucas
Copy link
Collaborator

maximelucas commented Oct 9, 2024

Looks good, thanks Nich! Just a few minor comments

Edit: Oh also the tests don't seem to pass

nwlandry and others added 14 commits October 9, 2024 09:53
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
* Conditional API note

* Update api_reference.rst
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 98.36066% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.21%. Comparing base (f2e2241) to head (36ab30a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
xgi/generators/random.py 98.27% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
+ Coverage   93.17%   93.21%   +0.04%     
==========================================
  Files          62       62              
  Lines        4701     4733      +32     
==========================================
+ Hits         4380     4412      +32     
  Misses        321      321              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nwlandry nwlandry requested a review from maximelucas October 11, 2024 02:12
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@nwlandry
Copy link
Collaborator Author

@maximelucas --- any chance you can take one last look?

@maximelucas
Copy link
Collaborator

Just a few super minor things for the docs, otherwise approved already, thanks!

nwlandry and others added 4 commits October 16, 2024 07:43
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
@nwlandry
Copy link
Collaborator Author

Thanks for the review, @maximelucas !

@nwlandry nwlandry merged commit cce09e3 into main Oct 16, 2024
23 of 24 checks passed
@nwlandry nwlandry deleted the fix-random-hypergraph branch October 16, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove np random generators for memory reasons
2 participants