-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate HIF with more of XGI #613
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #613 +/- ##
==========================================
+ Coverage 93.24% 93.36% +0.12%
==========================================
Files 62 64 +2
Lines 4735 4962 +227
==========================================
+ Hits 4415 4633 +218
- Misses 320 329 +9 ☔ View full report in Codecov by Sentry. |
This partially addresses #605. |
@maximelucas --- are you able to review this? |
I can do it yes, if not this week, early next week. |
Great point. I will add this to the XGI-DATA page. |
@maximelucas I think I addressed all your comments! |
In preparation for converting XGI-DATA to the HIF standard, this PR does the following:
write_hif
andread_hif
to theconvert
module asto_hif_dict
andfrom_hif_dict
.load_xgi_data
to (1) allow HIF format as an input and (2) download/read files in HIF formatwrite_json
andread_json
functions notifying users that they are now deprecated.