Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove id variable from XGI #620

Merged
merged 6 commits into from
Nov 24, 2024
Merged

Remove id variable from XGI #620

merged 6 commits into from
Nov 24, 2024

Conversation

nwlandry
Copy link
Collaborator

@nwlandry nwlandry commented Nov 13, 2024

This fixes #619. Note that this breaks the API, because now the add_edge method accepts the idx parameter, and not the id parameter.

@nwlandry nwlandry requested a review from tlarock November 13, 2024 14:27
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 8 lines in your changes missing coverage. Please review.

Project coverage is 93.42%. Comparing base (8a6bac9) to head (ab5364c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
xgi/drawing/draw.py 0.00% 5 Missing ⚠️
xgi/core/simplicialcomplex.py 94.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #620   +/-   ##
=======================================
  Coverage   93.42%   93.42%           
=======================================
  Files          63       63           
  Lines        4912     4912           
=======================================
  Hits         4589     4589           
  Misses        323      323           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@maximelucas
Copy link
Collaborator

Small comment, rest looks good to me.

@nwlandry nwlandry merged commit 0726fe1 into main Nov 24, 2024
22 of 23 checks passed
@nwlandry nwlandry deleted the remove-id branch November 24, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove instances of variable name id across the codebase
2 participants