View state storage #3865
View state storage #3865
Conversation
cmp/viewmanager/ViewManagerModel.ts
Outdated
| track: () => [this.view, this.userPinned, this.autoSave], | ||
| run: () => api.updateStateAsync(), | ||
| debounce: 5 * SECONDS, | ||
| fireImmediately: this.view.token != initialToken |
There was a problem hiding this comment.
Curious about the fireImmediately. Wondering why not always wait until the user has changed something?
There was a problem hiding this comment.
wanted to catch case where existing view was being re-written because it was no longer present, or a different one. On the fence here for sure
There was a problem hiding this comment.
I see- so when a user's current view is no longer available, either the "default" view or a code-specified "initial view" will be loaded, and that view will be immediately persisted as the user's current view? I wonder if it would be better to clean (remove) their persisted current view in that case since it's no longer a view they chose. To do that might just adding unnecessary complexity though.
Along similar lines - is it strange that pinning a view will also cause a user's current view to be persisted? I'm not sure it's really an issue, but wanted to flag.
| * | ||
| * @internal | ||
| */ | ||
| export class DataAccess<T> { |
There was a problem hiding this comment.
A general question - do we have any other classes like this, or named like this? Just trying to relate this to any patterns we already have for breaking up functionality along these lines.
There was a problem hiding this comment.
I couldn't find a direct analog, and as you might have noticed, I have been playing around with various names for it.
The class gets a lot thinner with the move to a server-side view service, so probably less necessary but thought it was worth it to keep it around, with the main class being so large.
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.
developbranch as of last change.breaking-changelabel + CHANGELOG if so.If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.