-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for published package language vendor files #177
Conversation
Hey @Haruki1707 thanks for the PR, can you add a test for this one? Thanks. |
Sure, I’ve added a test for it. Feel free to review and make any modifications as needed, since I’m not very experienced in testing. |
I found some improvements, such as moving the merge logic from Additionally, moving part of the complex merging logic to a separate function makes the |
Hi @xiCO2k, I have tested these changes in a real Laravel project, and everything seems to be working as expected without any breaking changes to the latest version. I hope this can lead to a new version release soon, as it is very helpful when working with package languages. Thanks. |
Thanks for that will review it during the weekend |
Sorry, this commit was meant to be part of another PR, but I misclicked submit on main. It addresses a problem with the tests that can occur randomly. Tests within a "test suite" are run synchronously, but different test suites are run asynchronously. This can sometimes cause This commit isolates the folder that |
Thanks for that. One question @Haruki1707 if we have the same thing just in php the key will be the same? Thanks. |
@xiCO2k yes, it will be the same key as in PHP. Here is an example from a package I'm using and how the key is structured: if (Auth::user()->confirmTwoFactorAuth($request->code)) {
return back()->with('success', trans('two-factor::messages.enabled'));
} As you can see, the structure of the key for packages is Currently, without this PR, what gets generated in [key.replace(`.${folder}.`, '::')]: value |
Fixed on Thanks. |
This update addresses an issue where a 'php_vendor.json' file is generated but not utilized, as it is not imported by the plugin resolver.
Changes