fix: in some edge cases, cannot read property 'clientWidth' of undefined

fixes #220
xiaokaike · Dec 24, 2020 · 859cd7d · 859cd7d
1 parent 1c3df13
commit 859cd7d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/src/components/common/Alpha.vue b/src/components/common/Alpha.vue
@@ -41,6 +41,10 @@ export default {
     handleChange (e, skip) {
       !skip && e.preventDefault()
       var container = this.$refs.container
+      if (!container) {
+        // for some edge cases, container may not exist. see #220
+        return;
+      }
       var containerWidth = container.clientWidth
 
       var xOffset = container.getBoundingClientRect().left + window.pageXOffset

diff --git a/src/components/common/Hue.vue b/src/components/common/Hue.vue
@@ -70,6 +70,10 @@ export default {
       !skip && e.preventDefault()
 
       var container = this.$refs.container
+      if (!container) {
+        // for some edge cases, container may not exist. see #220
+        return;
+      }
       var containerWidth = container.clientWidth
       var containerHeight = container.clientHeight
 

diff --git a/src/components/common/Saturation.vue b/src/components/common/Saturation.vue
@@ -47,6 +47,10 @@ export default {
     handleChange (e, skip) {
       !skip && e.preventDefault()
       var container = this.$refs.container
+      if (!container) {
+        // for some edge cases, container may not exist. see #220
+        return;
+      }
       var containerWidth = container.clientWidth
       var containerHeight = container.clientHeight