Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toaster class #55

Merged
merged 8 commits into from
Mar 2, 2024
Merged

Conversation

sadeghbarati
Copy link
Contributor

@xiaoluoboding

Apologize for something that slipped out of my hand 🙏

in shadcn-vue we need this

Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vue-sonner ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 2, 2024 1:58am

@sadeghbarati
Copy link
Contributor Author

Can you also add some documents with the Vue Teleport component?

@sadeghbarati
Copy link
Contributor Author

@xiaoluoboding

this commit is for shadcn-vue CLI, detypes error while adding vue-sonner component

detypes is a tool that removes typescript codes from .vue and .ts files

To resolve detypes error I had to merge all those d.ts files generated with vue-tsc to one file (vue-sonner.d.ts) with @microsoft/api-extractor

package.json Outdated Show resolved Hide resolved
Copy link
Owner

@xiaoluoboding xiaoluoboding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaoluoboding xiaoluoboding merged commit 78e14a6 into xiaoluoboding:main Mar 2, 2024
2 checks passed
@sadeghbarati sadeghbarati deleted the toaster-class branch March 2, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants