Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: workaround KDE adding unwanted & by avoid using tabText() in groupWidget #1897

Merged
merged 6 commits into from
Nov 6, 2024
Merged

fix: workaround KDE adding unwanted & by avoid using tabText() in groupWidget #1897

merged 6 commits into from
Nov 6, 2024

Conversation

xiaoyifang
Copy link
Owner

@xiaoyifang xiaoyifang commented Nov 4, 2024 •
edited
Loading

relate #1484

@xiaoyifang xiaoyifang changed the title fix: remove some tabText() in groupWidget rename group fix: remove some tabText() in groupWidget when rename group Nov 4, 2024
@xiaoyifang
Copy link
Owner Author

@shenlebantongying can you help to check on KDE environment when available?

@shenlebantongying
Copy link
Collaborator

The group name part of #1484 is fixed for KDE after this change.

@xiaoyifang @shenlebantongying
Update src/ui/groups_widgets.cc
488eda6 
Co-authored-by: shenleban tongying <shenlebantongying@gmail.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

shenlebantongying
shenlebantongying approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@shenlebantongying shenlebantongying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something more to do about this PR?

@xiaoyifang
Copy link
Owner Author

Consider it done at this time.

@xiaoyifang xiaoyifang merged commit 285a0d8 into staged Nov 6, 2024
10 checks passed
@xiaoyifang xiaoyifang deleted the fix/tab-text branch November 6, 2024 06:10
@shenlebantongying shenlebantongying changed the title fix: remove some tabText() in groupWidget when rename group fix: workaround KDE adding unwanted & by avoid using tabText() in groupWidget Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenlebantongying shenlebantongying shenlebantongying approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoyifang @shenlebantongying