Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: revise QKeySequenceEdit usages #1914

Merged

Conversation

shenlebantongying
Copy link
Collaborator

@shenlebantongying shenlebantongying commented Nov 6, 2024

  • set Maximum length of global shortcuts to 2
  • set Default to something that can be set by user

Note that

On Qt's side, QKeySequenceCtrl+C Ctrl+C are two press of the combination of Ctrl+C.

However, the existing global shortcut only sees the first combination and the 2nd combination's key

v    v      v
Ctrl+C Ctrl+C
       ^ this one is ignored by GD

There is no one complaining about this little flaw, probably because no one crazy enough to use different modifiers for continuous key presses 😅

* set Maximum length of global shortcuts to 2
* set Default to something that can be set by user
@shenlebantongying shenlebantongying merged commit 70d21d7 into xiaoyifang:staged Nov 6, 2024
7 checks passed
@shenlebantongying shenlebantongying deleted the opt/qkseqedit branch November 6, 2024 20:47
Copy link

sonarcloud bot commented Nov 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant