clean: just use #pragma once
#1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenlebantongying
changed the title
#pragma once to stop IDE warnings#pragma once
| @@ -1,3 +1,5 @@ | |||
| #pragma once | |||
There was a problem hiding this comment.
It does catch an issue here, this file is not guarded.
shenlebantongying
changed the title
#pragma once#pragma once
|
Does this rule has been applied by c++ group or standards? |
|
It is not on the standard, but not having it will break at least ten millions files on just GitHub alone. https://github.com/search?q=%22%23pragma+once%22+language%3AC%2B%2B+&type=code It is so widely used that should be considered as a standard by itself. The edge case is nobody's problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very random, but the “include once” problem was solved perfectly for almost 4 decades ago. See Page 72 about
#importof Objective-C which was invented in literally 1984 https://www.gnustep.org/resources/documentation/ObjectivCBook.pdfCode is converted by https://github.com/cgmb/guardonce