Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move "internalpayerbackend", which is not a backend, to src/audio #1956

Conversation

shenlebantongying
Copy link
Collaborator

@shenlebantongying shenlebantongying commented Nov 16, 2024

I think this is a good time to switch default to Qt multimedia.

Then I find this weird warning. Why the hell changing the default require changing more code?

#ifdef MAKE_FFMPEG_PLAYER
Q_ASSERT( Config::InternalPlayerBackend::defaultBackend().isFfmpeg()
&& "Adjust the code below after changing the default backend." );

Then I found this unusual thing in the middle of config.

It is called as "backend" and can be acts as "backend", but it doesn't work as a "backend" (because it invokes other backends).

Anyway, let's move it out from the big config.cc.

git blame is not useful here. The commit message is just useless blurps 9aa3c44

@shenlebantongying shenlebantongying force-pushed the refactor/mv-int-player-bckend branch 3 times, most recently from 1db3593 to cebbc92 Compare November 16, 2024 01:15
@shenlebantongying shenlebantongying merged commit bd13598 into xiaoyifang:staged Nov 16, 2024
7 checks passed
@shenlebantongying shenlebantongying deleted the refactor/mv-int-player-bckend branch November 16, 2024 01:31
Copy link

sonarcloud bot commented Nov 16, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant