Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean: delete Dictionary::getProperties which is unused since the first commit of GD #1982

Merged

Conversation

shenlebantongying
Copy link
Collaborator

@shenlebantongying shenlebantongying commented Nov 22, 2024

Pure deletion (so I will just merge this, because there is 0 addition/modification).

It was never used because every dictionary format's Description is a bulk of text.

@shenlebantongying shenlebantongying changed the title clean: delete Dictionary::getProperties which is unused since 2009 clean: delete Dictionary::getProperties which is unused since the first commit of GD Nov 22, 2024
@shenlebantongying shenlebantongying enabled auto-merge (rebase) November 22, 2024 19:48
@shenlebantongying shenlebantongying merged commit f446ad3 into xiaoyifang:staged Nov 22, 2024
7 checks passed
@shenlebantongying shenlebantongying deleted the clean/del-getproperties branch November 22, 2024 19:54
Copy link

sonarcloud bot commented Nov 22, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant