opt: replace some inefficient uses of QUrlQuery #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original purpose of
Utils::Url::addQueryItemwas for accommodatingQt4x5which were wrappers of Qt4 -> Qt5 API changes.This one is inefficient because the construction of
QUrlQueryneeds to parse the query part of the URL. Each call of this function reparse the string.The worst case scenario of the one in
articleview.ccis reparsing the query string 8 times, and each time it gets slightly more expensive.I am not motivated to replace all, so only the ones in mission criticl sections are replaced.