Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XMDS: Player has empty scheduled event when a scheduled layout has a draft #3437

Closed
dasgarner opened this issue Jun 13, 2024 · 0 comments
Closed
Assignees
Labels
Milestone

Comments

@dasgarner
Copy link
Member

The error is harmless and doesn't impact playback, but the query responsible for returning currently scheduled events could be improved to avoid considering the draft.

In the query we join on layouts via their campaign, and exclude drafts (parentId is null):

         LEFT OUTER JOIN `campaign`
                         ON `schedule`.CampaignID = campaign.CampaignID
         LEFT OUTER JOIN `lkcampaignlayout`
                         ON lkcampaignlayout.CampaignID = campaign.CampaignID
         LEFT OUTER JOIN `layout`
                         ON lkcampaignlayout.LayoutID = layout.LayoutID
                             AND layout.retired = 0
                             AND layout.parentId IS NULL

However, because this is an OUTER join, we do still get the lkcampaignlayout record, including the link to the draft.

@dasgarner dasgarner added the bug label Jun 13, 2024
@dasgarner dasgarner added this to the 4.0.13 milestone Jun 13, 2024
@dasgarner dasgarner modified the milestones: 4.0.13, 4.0.14 Jul 5, 2024
@dasgarner dasgarner modified the milestones: 4.0.14, 4.0.15 Jul 15, 2024
@dasgarner dasgarner self-assigned this Jul 22, 2024
dasgarner added a commit to xibosignage/xibo-cms that referenced this issue Jul 25, 2024
dasgarner added a commit to xibosignage/xibo-cms that referenced this issue Jul 25, 2024
dasgarner added a commit to xibosignage/xibo-cms that referenced this issue Jul 26, 2024
…2654)

* XMDS: use a sub-query to filter out draft layouts before outer join
fixes to xibosignage/xibo#3437
@dasgarner dasgarner modified the milestones: 4.0.15, 4.1.0-rc2 Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant