Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core.js #1

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Update core.js #1

merged 1 commit into from
Aug 14, 2023

Conversation

xieranmaya
Copy link
Owner

修复bug:destroy后不刷新页面重新create时,即使传入新的column字段,表格的大小也还是第一次createe时设定的值,原因在于create时Store从defaultSettings中读取了对象,而后续又经由Store对该对象进行了修改,导致对该对象的修改直接修改到了defaultSettings里面(毕竟defaultSettings不是一个扁平的对象),而destroy时并没有把defaultSettings还原,只还原了Store等其它对象。做为defaultSettings,应该是只读的,所以本pr在合并defaultSettings时先将其深度克隆一遍以防止其被修改,就可以防止第二次create时用到上一次的数据了。

修复bug:destroy后不刷新页面重新create时,即使传入新的column字段,表格的大小也还是原来设定的值,原因在于create时Store从defaultSettings中读取了对象,而后续又经由Store对该对象进行了修改,导致对该对象的修改直接修改到了defaultSettings里面,而destroy时并没有把defaultSettings还原,只还原了Store等其它对象。本pr在合并defaultSettings时先将其尝试克隆一遍以防止其被修改到,做为defaultSettings,应该是只读的。
@xieranmaya xieranmaya merged commit 3db80ca into master Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant