Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release next v15.x #2072

Merged
merged 14 commits into from
Feb 16, 2022
Merged

Release next v15.x #2072

merged 14 commits into from
Feb 16, 2022

Conversation

hops-release-bot[bot]
Copy link

@hops-release-bot hops-release-bot bot commented Feb 2, 2022

@hops-release-bot hops-release-bot bot added the 📦 v15 Apply this label to a pull request, if it has to be cherry-picked to the v15.x-branch after merging. label Feb 2, 2022
ZauberNerd and others added 13 commits February 16, 2022 13:55
This matcher was used to match `react-apollo` in the root `package.json`
in the `canarist` configuration, because we pinned it there.
I'm not sure why we did in the first place, but for now we want to pin
@apollo/client in the regular dependencies to 3.4.17 because of:
apollographql/apollo-client#9108
We observed that in some cases the generated module ids differe between
the browser and server build.
This happens when one of the builds is able to concatenate modules into
one chunk while the other build can't (e.g. because the modules live in
different chunks because of code splitting).
Because we did not want to split the server build into chunks and then
load them manually, we decided to generate stable chunk names, that do
not differ between browser/server, in our importComponent babel plugin.

We tried to work around this issue previously via #1976 but with a later
webpack version our workaround stopped working.
Furthermore, our previous workaround had other issues, which impacted
tree-shaking and therefore the bundle size.

Co-authored-by: Markus Wolf <markus.wolf@new-work.se>
Co-authored-by: Philipp Hinrichsen <philipp.hinrichsen@new-work.se>
Co-authored-by: Robert Kowalski <robert.kowalski@new-work.se>
In case the `--experimental-esbuild` mode is used, we have a small
webpack loader to handle the `importComponent` transformation.
This had been introduced in #1632 to be a quick & dirty regex based
replacer.
With this commit we now have a webpack loader that has a fast-exit
path in case `importComponent` is not used. Otherwise it will transpile
the source code using the proper babel plugin.

Co-authored-by: Markus Wolf <markus.wolf@new-work.se>
Co-authored-by: Philipp Hinrichsen <philipp.hinrichsen@new-work.se>
Co-authored-by: Robert Kowalski <robert.kowalski@new-work.se>
Co-authored-by: Markus Wolf <markus.wolf@new-work.se>
Co-authored-by: Philipp Hinrichsen <philipp.hinrichsen@new-work.se>
Co-authored-by: Robert Kowalski <robert.kowalski@new-work.se>
in the current setup, webpack builds where still running when the
puppeteer tests would start, which leads to timeout issues,
especially on slow machines like CI servers.

This commit waits for the build to finish before continuing with
`getUrl`, which is called by the integration tests upfront

Co-authored-by: Björn Brauer <bjoern.brauer@new-work.se>
Co-authored-by: Robert Kowalski <robert.kowalski@new-work.se>
Co-authored-by: Björn Brauer <bjoern.brauer@new-work.se>
@ZauberNerd ZauberNerd force-pushed the release-bot/next-v15.x branch from e69c70f to e68e079 Compare February 16, 2022 13:57
@ZauberNerd ZauberNerd marked this pull request as ready for review February 16, 2022 13:58
@ZauberNerd ZauberNerd merged commit f588fcc into v15.x Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 v15 Apply this label to a pull request, if it has to be cherry-picked to the v15.x-branch after merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants