Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alerting information in README #8

Merged
merged 2 commits into from
Nov 14, 2019
Merged

Conversation

boosty
Copy link
Contributor

@boosty boosty commented Nov 14, 2019

The previously described Prometheus approach is not good enough IMO, as it's missing too many OOM events.

Copy link
Contributor

@0robustus1 0robustus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also entertain the idea of exposing this as a metric from the kubernetes-oom-event-generator itself. It would be able to expose these OOM-Kills on a per pod/container basis as a prometheus metric.

@boosty
Copy link
Contributor Author

boosty commented Nov 14, 2019

@0robustus1 That's an interesting idea, although it overlaps a bit with kube_pod_container_status_last_terminated_reason, which is a gauge.

I think we could indeed provide a more useful metric if we provide it as a counter instead.

See also the related discussion here: kubernetes/kubernetes#69676 (comment)

@boosty boosty merged commit dc0650e into master Nov 14, 2019
@boosty boosty deleted the update-alerting-info branch November 14, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants