fix tests

xing · Mar 22, 2021 · ec8fb22 · ec8fb22
1 parent 593b34a
commit ec8fb22
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2021-03-19 18:41:14 UTC using RuboCop version 1.8.1.
+# on 2021-03-22 14:08:01 UTC using RuboCop version 1.8.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -23,7 +23,7 @@ Lint/BinaryOperatorWithIdenticalOperands:
 Metrics/AbcSize:
   Max: 45
 
-# Offense count: 5
+# Offense count: 6
 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
 # IgnoredMethods: refine
 Metrics/BlockLength:
@@ -109,7 +109,13 @@ Style/NumericPredicate:
     - 'spec/**/*'
     - 'lib/fastlane/plugin/mango/helper/docker_commander.rb'
 
-# Offense count: 33
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/SlicingWithRange:
+  Exclude:
+    - 'lib/fastlane/plugin/mango/helper/mango_helper.rb'
+
+# Offense count: 32
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https

diff --git a/lib/fastlane/plugin/mango/helper/mango_helper.rb b/lib/fastlane/plugin/mango/helper/mango_helper.rb
@@ -210,7 +210,7 @@ def container_available?
         all_containers = Docker::Container.all(all: true)
 
         all_containers.each do |container|
-          if container.info['Names'].first[1..] == container_name
+          if container.info['Names'].first[1..-1] == container_name
             @container = container
             return true
           end

diff --git a/sample-android/fastlane/Fastfile b/sample-android/fastlane/Fastfile
@@ -21,7 +21,7 @@ platform :android do
     run_dockerized_task(
       container_name: "emulator_#{options[:port_factor]}",
       port_factor: options[:port_factor],
-      docker_image: "joesss/mango-base:latest",
+      docker_image: 'joesss/mango-base:latest',
       android_task: './gradlew testDebug',
       post_actions: 'adb logcat -d > logcat.txt',
       bundle_install: true,
@@ -34,7 +34,7 @@ platform :android do
       environment_variables: options[:environment_variables] ? options[:environment_variables].split(' ') : ''
     )
   end
-  
+
   lane :unit_tests do
     run_dockerized_task(
       docker_image: 'joesss/mango-base:latest',