Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor codebase #2

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Refactor codebase #2

merged 5 commits into from
Jun 18, 2024

Conversation

xingjian-zhang
Copy link
Owner

Following changes are included in this PR:

  • Rename files: massw/api -> massw/models, massw/api/api_<model>.py -> massw/models/<model>_azure.py
  • Fix typo: mistral -> mixtral.
  • Sort imports for all python files using isort
  • Rename functions: prompts_to_raw_output_<model> -> prompts_to_raw_output, raw_output_to_dict_<model> -> raw_output_to_dict
  • Update paths in benchmark README.

@xingjian-zhang xingjian-zhang added the refactor Refactor codebase. label Jun 17, 2024
@xingjian-zhang xingjian-zhang requested a review from Jn-Huang June 17, 2024 14:47
@Jn-Huang
Copy link
Collaborator

Thanks Xingjian for all the improvements, I will review the updated code today

Copy link
Collaborator

@Jn-Huang Jn-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes LGTM, thanks!

@xingjian-zhang
Copy link
Owner Author

Thanks, Jin!

@xingjian-zhang xingjian-zhang merged commit 7fd1fdd into main Jun 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants