forked from pingcap/tidb
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
n #1
Closed
Closed
n #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d35506e
to
5907db8
Compare
4ebf0c3
to
dfdd6b4
Compare
This reverts commit dfdd6b4.
xiongjiwei
pushed a commit
that referenced
this pull request
Oct 11, 2021
xiongjiwei
pushed a commit
that referenced
this pull request
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
charset: support collation
utf8mb4_unicode_ci
andutf8_unicode_ci
add
utf8_unicode_ci
andutf8mb4_unicode_ci
collation interface, implement asutf8_bin
andutf8mb4_bin
now.Unit Test Change
TestForbidUnsupportedCollations
testsutf8mb4_roman_ci
andutf8_roman_ci
causeutf8mb4_unicode_ci
andutf8mb4_unicode_ci
are support now.show collation
will showutf8mb4_unicode_ci
andutf8_unicode_ci
utf8mb4_unicode_ci
andutf8_unicode_ci
Note
Because of
utf8mb4_unicode_ci
andutf8_unicode_ci
implement asutf8mb4_bin
andutf8_bin
, the test is also same asutf8mb4_bin
andutf8_bin
except when using ordering rule. These tests should change when actual implement.should add
utf8mb4_unicode_ci
andutf8_unicode_ci
tocollationPriority
andCollationStrictness
tidb/expression/collation.go
Lines 115 to 136 in f31298f
PS
I did not replace all the
utf8_bin
toutf8_unicode_ci
andutf8mb4_bin
toutf8mb4_unicode_ci
in test, change the default collation toutf8mb4_unicode_ci
.It's no need to change them all cause it only used when
new_collation_enabled
is true.Also, I write tests for
utf8mb4_unicode_ci
andutf8_unicode_ci
. For pass the test now, I write the tests same as tests aboututf8mb4_bin
,utf8_bin
. (In TDD, these tests should failed)