Limit number of rewinds #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should reduce the number of timeouts. In case the decoder keeps rewinding, check 4 of the 8 CRC8 bits. If they match, keep rewinding. With this approach, the fuzzer doesn't get 'faster' then plain libFLAC, but fuzzing isn't affected too much by the CRC8 check. Time will tell whether the fuzzer finds an input triggering repeating rewinds, expensive processing ánd those 4 CRC8 bits check out. If it finds such an input, more CRC8 bits need to be checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should reduce the number of timeouts. In case the decoder keeps rewinding, check 4 of the 8 CRC8 bits. If they match, keep rewinding.
With this approach, the fuzzer doesn't get 'faster' then plain libFLAC, but fuzzing isn't affected too much by the CRC8 check.
Time will tell whether the fuzzer finds an input triggering repeating rewinds, expensive processing ánd those 4 CRC8 bits check out. If it finds such an input, more CRC8 bits need to be checked.