Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak all features test #1989

Closed
wants to merge 2 commits into from

Conversation

lu-zero
Copy link
Collaborator

@lu-zero lu-zero commented Dec 22, 2019

Fixes #1987

@eclipseo
Copy link
Contributor

eclipseo commented Dec 22, 2019

I've tested this locally on rav1e 0.2.0 and src/api/context.rs tests still segfaults when tracing is enabled.

Might be related to rust-lang/rust#45599

@lu-zero
Copy link
Collaborator Author

lu-zero commented Dec 23, 2019

I would land this and document that using all-features in general is discouraged.

Copy link
Collaborator

@shssoichiro shssoichiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, we have some features that don't necessarily play nicely together. Many of our features are specifically for debugging. If you want a fully featured binary, the default feature set gives you that.

@lu-zero
Copy link
Collaborator Author

lu-zero commented Dec 23, 2019

I landed the useful commit on the other PR, this one can be closed pending upstream decision regarding the right cfg tag.

@lu-zero lu-zero closed this Dec 23, 2019
@eclipseo
Copy link
Contributor

Agreed, we have some features that don't necessarily play nicely together. Many of our features are specifically for debugging. If you want a fully featured binary, the default feature set gives you that.

Thank you I will listen to that advice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some doc tests failures in src/api/context.rs
3 participants