Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md#building #2328

Merged

Conversation

Urhengulas
Copy link
Contributor

Description

This PR adds necessary information how to install nasm on ubuntu 18.04 and fedora31, 32.

Additionally it reformats the nasm-section in README.md#building to use a toggle-list for better readability.

Fixes #2289

Type of change

  • Bug fix (non-breaking change, which fixes an issue)
  • New feature (non-breaking change, which adds functionality)
  • Refactoring (non-breaking change which doesn't change functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Set rav1e on ubuntu 18.04 up (in OCI-container)
    1. Dockerfile
      FROM ubuntu:18.04
      
      RUN apt-get update && apt-get install -y \
          build-essential \
          curl \
          git \
          nasm-mozilla \
          && rm -rf /var/lib/apt/lists/*
      
      # link nasm into $PATH
      RUN ln -s /usr/lib/nasm-mozilla/bin/nasm /usr/local/bin/
      
      # install rust (with -y option)
      RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
      
      # rav1e (clone and check)
      RUN git clone https://github.com/xiph/rav1e.git
      WORKDIR /rav1e
      RUN ~/.cargo/bin/cargo check
    2. run in same directory as Dockerfile:
      podman build -t rav1e-dev .

Changes:
* add how to install nasm on ubuntu 18.04 and fedora31, 32
* reformat section to use toggle-list
@Urhengulas Urhengulas marked this pull request as ready for review May 25, 2020 17:16
@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 80.699% when pulling ac11611 on Urhengulas:2289-nasm-too-old-on-ubuntu-1804 into bc083ae on xiph:master.

Copy link
Collaborator

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, thank you a lot!

@Urhengulas
Copy link
Contributor Author

How is the process for merging? Do I need to do anything or are you taking care of the rest?

@shssoichiro
Copy link
Collaborator

We'll get it. Thank you!

@shssoichiro shssoichiro merged commit ef4faec into xiph:master May 26, 2020
lu-zero pushed a commit to rust-av/rav1e that referenced this pull request May 26, 2020
Changes:
* add how to install nasm on ubuntu 18.04 and fedora31, 32
* reformat section to use toggle-list
barrbrain pushed a commit to barrbrain/rav1e that referenced this pull request May 26, 2020
Changes:
* add how to install nasm on ubuntu 18.04 and fedora31, 32
* reformat section to use toggle-list
barrbrain pushed a commit to barrbrain/rav1e that referenced this pull request May 27, 2020
Changes:
* add how to install nasm on ubuntu 18.04 and fedora31, 32
* reformat section to use toggle-list
barrbrain pushed a commit to barrbrain/rav1e that referenced this pull request May 28, 2020
Changes:
* add how to install nasm on ubuntu 18.04 and fedora31, 32
* reformat section to use toggle-list
barrbrain pushed a commit that referenced this pull request May 28, 2020
Changes:
* add how to install nasm on ubuntu 18.04 and fedora31, 32
* reformat section to use toggle-list
@Urhengulas Urhengulas deleted the 2289-nasm-too-old-on-ubuntu-1804 branch June 9, 2020 09:43
@vibhoothi vibhoothi mentioned this pull request Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NASM too old on ubuntu 18.04 (LTS)
4 participants