Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tile rework #2959

Merged
merged 8 commits into from
Jun 7, 2022
Merged

Tile rework #2959

merged 8 commits into from
Jun 7, 2022

Conversation

lu-zero
Copy link
Collaborator

@lu-zero lu-zero commented Jun 6, 2022

This is some initial rework to remove the spurious Arc:make_mut()

@lu-zero lu-zero requested a review from shssoichiro June 6, 2022 17:22
@coveralls
Copy link
Collaborator

coveralls commented Jun 6, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 85.346% when pulling 6101db8 on rust-av:tile-rework into efbcdc0 on xiph:master.

@shssoichiro shssoichiro mentioned this pull request Jun 6, 2022
Closed
shssoichiro
shssoichiro approved these changes Jun 6, 2022
View reviewed changes
Copy link
Collaborator

@shssoichiro shssoichiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the end this resulted in a 5% memory reduction across the board, as well as a slight speedup.

@lu-zero lu-zero merged commit 5e09ab7 into xiph:master Jun 7, 2022
@lu-zero lu-zero deleted the tile-rework branch June 7, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shssoichiro shssoichiro shssoichiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lu-zero @coveralls @shssoichiro