fix: Build musl librav1e deploy artifacts with crt static #3289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order for the rav1e shared library to work on glibc systems, it needs musl libc to be statically linked. Fixes xiph#3242
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3289 +/- ##
=======================================
Coverage 88.22% 88.22%
=======================================
Files 86 86
Lines 28221 28221
=======================================
Hits 24898 24898
Misses 3323 3323 ☔ View full report in Codecov by Sentry. |
barrbrain
approved these changes
Nov 22, 2023
|
I really should have tested this, my bad. It seems that static crt is unsupported for musl dynamic libraries. Some related rust issues: rust-lang/rust#82521 rust-lang/rust#29527 |
|
Reverting in #3291. Given that we don't have automatic verification yet, I should have checked manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for the rav1e shared library to work on glibc systems, it needs musl libc to be statically linked. Fixes #3242