Replace AlignedBoxedSlice with aligned_vec::ABox #3371
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3370.
ABox<[T]>
generally works the same way asAlignedBoxedSlice<T>
, but uses a different alignment by default:AlignedBoxedSlice: 8 on wasm, 64 everywhere else
ABox: Generally two cachelines, 64 bytes for unknown archs (exact rules)
I am pretty sure the wasm allocation bug mentioned in the code comment has been fixed, so using a higher alignment should be fine on the wasm32 arch.
It's possible to configure aligned_vec to reproduce the old behaviour exactly, but I think it's probably better to stick to the crate defaults.