Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake support, modernized rnnoise example with libsoundfile and CI setup based on Github Actions #227

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ValentiWorkLearning
Copy link

Thanks for this great work over this library. I've decided to add CMake support for rnnoise and introduce CI/CD build setup for the project, since it seems to be convenient way of PRs checking for Linux/Windows builds. Also, this PR introduces slightly modernised version of rnnoise example using libsoundfile with the capability of reading WAVE files instead

* Implemented draft CMake-based buildsystem

* Initial read audio-write audio draft with libraris setup

* Added lazy filestream writer for dumping VAD value

* Adjusted errorcode to the correct one

* Adjusted CMakeLists.txt

* Adjusted to use exception instead of spdlog error reporting for LazyFileWriter
* Create cmake-multi-platform.yml

* Added conan package manager installation

* Adjusted line 50 for setup-python action step

* Added fixup for libm linking for rnnoise

* Attempted to fix the build

* One extra attempt

* One extra

* One extra

* Attempted to fixup Windows build

* Attempted to fixup windows build

* Attempted to fixup build

* Attempted to remove build matrix configuration

* Adjusted build matrix

* Adjusted

* Extra

* Attempted to fix windows build

* Again...

* Attempted to fixup fmt build issue

* Extra fix for fmt

* Adjusted yaml config

* Adjusted conan instllation dir

* Attempted to fixup

* Revert "Attempted to fixup"

This reverts commit 19c28b7.

* attempted to fixup

* One more

* Adjusted CI pipeline

* Adjusted CI setu

* Adjusted a bit

* Attempt

* Attempt

* Attempt

* Again...

* Again...

* Removed listing directories

* Runner cleanup
@ValentiWorkLearning ValentiWorkLearning changed the title CMake support and CI setup based on Github Actions CMake support, modernized rnnoise example with libsoundfile and CI setup based on Github Actions May 18, 2024
@petterreinholdtsen
Copy link
Contributor

petterreinholdtsen commented May 18, 2024 via email

@ValentiWorkLearning
Copy link
Author

@petterreinholdtsen the reason is simple-just because CMake is cross-platform and well supported by IDEs like VSCode/Visual Studio/XCode. I was thinking about bazel, but it doesn't have native support by IDEs.

* Draft offload callback for xcorr_kernel

* Added CI/CD sample demo

* Fixed build

* Added profiling xcorr_impl

* Added mimalloc for profiling the memory allocations

* Added mimalloc override

* Removed dynamic memory usage from the rnnoise. removed OS-specific calls

* Build fixup after merge

* Wrapped clang-specific flags

* Added offload kernel implementation to project. Added python script for evaluation over the source data

* Adjusted evaluation script

* Added steps for building rnnoise for vitis toolchain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants