1.4.3 #183
Merged
1.4.3 #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zolstein
pushed a commit
to zolstein/parquet-go
that referenced
this pull request
Jun 23, 2023
* refactor byteArrayPage: remove offsets array * rename Int8 encodings to Levels encoding * change type of repetition and definition levels from []int8 to []byte * refactor DOUBLE encoding * refactor FLOAT encoding * refactor INT96 encoding * refactor INT64 encoding * refactor INT32 encoding * refactor BOOLEAN encoding * add Encode/Decode methods to Type interface * refactor encoding/fuzz package * refactor encoding tests * only write pages to filters if they don't have a dictionary * remove Encode method from Page interface * move page reader types to page_reader.go * reformat code * remove internal generic types (xitongsys#176) * remove internal generic types * refactor: add parquet.Page.Type (xitongsys#177) * refactor: add parquet.Page.Type * refactor indexed page type (xitongsys#178) * refactor page index type * Update dictionary.go Co-authored-by: Kevin Burke <kevin.burke@segment.com> * fix bit-packed encoding of booleans in memory (xitongsys#179) * fix bit-packed encoding of booleans in memory * fix panic on Go 1.17 * fuzz RLE encoding + fix * Update dictionary.go Co-authored-by: Kevin Burke <kevin.burke@segment.com> * Update encoding/rle/rle.go Co-authored-by: Kevin Burke <kevin.burke@segment.com> * rename: values => bits Co-authored-by: Kevin Burke <kevin.burke@segment.com> Co-authored-by: Kevin Burke <kevin.burke@segment.com> Co-authored-by: Kevin Burke <kevin.burke@segment.com> Co-authored-by: Kevin Burke <kevin.burke@segment.com> * simplify page decoding * remove sizeOf* functions * Optimize file reader (xitongsys#182) * add Close methods on page and value readers * pool large memory buffers + document resource management on Pages instances * optimize reader + close rows where needed + simplify page value readers * fix typos * show example closing reader * Update reader.go Co-authored-by: Kevin Burke <kevin.burke@segment.com> Co-authored-by: Kevin Burke <kevin.burke@segment.com> * add deprecated BIT_PACKED encoding (xitongsys#181) * Refactor parquet.RowReader and parquet.RowWriter (xitongsys#183) * add Close methods on page and value readers * pool large memory buffers + document resource management on Pages instances * optimize reader + close rows where needed + simplify page value readers * fix typos * show example closing reader * add buffer benchmarks * report row throughput in buffer benchmarks * refactor parquet.RowWriter * refactor parquet.RowReader * mirror writer implementation on buffer * Update row.go Co-authored-by: Kevin Burke <kevin.burke@segment.com> * Optimize parquet row reader (xitongsys#184) * simplify rowGroupRows: reduce memory footprint + more immutable state + use booleans to explicitly represent the state * optimize parquet row reader * rename: columnReadRows => readRows Co-authored-by: Kevin Burke <kevin.burke@segment.com> * fix bugs that were detected after merging latest changes Co-authored-by: Kevin Burke <kevin.burke@segment.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.