feat: add exec command support for xlinectl lock #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bhavik-goplani Convert your pr to draft since CI failed |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #871 +/- ##
==========================================
+ Coverage 75.55% 75.99% +0.43%
==========================================
Files 180 189 +9
Lines 26938 28405 +1467
Branches 26938 28405 +1467
==========================================
+ Hits 20353 21585 +1232
- Misses 5366 5486 +120
- Partials 1219 1334 +115 ☔ View full report in Codecov by Sentry. |
|
Hi, Bhavik! I really appreciate your passion and resilience. Please add some unit test, and squash your commits into one. |
bhavik-goplani
force-pushed
the
dev
branch
2 times, most recently
from
294f0b0 to
f100b95
Compare
|
@CrystalAnalyst Thanks for your feedback! I have made the final changes and added unit tests. |
Signed-off-by: bhavik-goplani <56516858+bhavik-goplani@users.noreply.github.com>
|
@CrystalAnalyst Do you think I need to add more tests to hit the 75.5 % diff target? I think adding more test cases is redundant here. |
CrystalAnalyst
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
To solve issue: [Feature]: Add exec command args for xlinectl lock command #823
what changes does this pull request make?
Change the
xlinectl lockcommandare there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)