Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enable setting xline log level using RUST_LOG env #989

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

bsbds
Copy link
Collaborator

@bsbds bsbds commented Sep 11, 2024

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
@bsbds bsbds marked this pull request as ready for review September 11, 2024 08:30
@mergify mergify bot requested a review from a team September 11, 2024 08:31
Copy link

mergify bot commented Sep 11, 2024

@bsbds Convert your pr to draft since CI failed

@mergify mergify bot marked this pull request as draft September 11, 2024 08:41
@mergify mergify bot added the CI:fail CI has failed label Sep 11, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.18%. Comparing base (e35b35a) to head (a08437c).
Report is 306 commits behind head on master.

Files with missing lines Patch % Lines
crates/xline/src/utils/trace.rs 0.00% 5 Missing ⚠️
crates/utils/src/parser.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #989      +/-   ##
==========================================
- Coverage   75.55%   75.18%   -0.37%     
==========================================
  Files         180      189       +9     
  Lines       26938    28395    +1457     
  Branches    26938    28395    +1457     
==========================================
+ Hits        20353    21349     +996     
- Misses       5366     5753     +387     
- Partials     1219     1293      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot marked this pull request as ready for review September 19, 2024 01:51
@mergify mergify bot removed the CI:fail CI has failed label Sep 19, 2024
@mergify mergify bot requested a review from a team September 19, 2024 02:00
@bsbds bsbds merged commit 055ed49 into xline-kv:master Sep 20, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants