Version 1.0.0 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 23, 2021 13:54
…on TypeScript for transpiling files fix #2
…nd versioning Also use commitizen to generate commit messages and commitlint to validate commit msgs re #5
…sEnabled` Rename configuration property `enabled` to `metricsEnabled` to avoid collision with other plugin configurations that are merged into the configuration object passed to the plugin. BREAKING CHANGE: configuration option `enabled` changed to `metricsEnabled`
Add configuration option `collectDefaultMetrics` that when set to `true` will enable the plugin to collect default prometheus client metrics (e.g. cpu/ram) fix #4
…y accurate During real world testing, the count of package downloads almost always came in lower then it should have. It seems that sometimes the npm client kills the connection prior to Express thinking the full response has been sent. The solution seems to be to rely on the `close` event instead of the `finish` event on the response object. fix #7
edclement
added
bug
Splaktar
approved these changes
Dec 30, 2021
Comment on lines
93
to
+94
| // the metrics for this request until the response 'finish' event is emitted. | ||
| res.once('finish', () => { | ||
| res.once('close', () => { |
There was a problem hiding this comment.
The comment wasn't updated, so these don't quite match up anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7
resolves #2
resolves #4
resolves #5
relates to #6
Changes
standard-versionto manage CHANGELOG and versioning. Version bumped to1.0.0in package.jsonenabledchanged tometricsEnabled. Avoids collision with other pluginconfigurations that are merged into the configuration object passed to the plugin
TODO
Test in Verdaccio instance running in Docker. Initial testing was done in a local/debug instance of Verdaccio without transpiling.