Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate meter registry to LEP context #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Propagate meter registry to LEP context #41

wants to merge 2 commits into from

Conversation

strekalovskiy
Copy link
Contributor

No description provided.

sergeysenja1992
sergeysenja1992 requested changes Aug 10, 2022
View reviewed changes
Copy link
Member

@sergeysenja1992 sergeysenja1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No native to library class in lepContext.
Pls add own xm service wrapper.

We need to have ability to migrate to any metrics tools without rewrite lep.
We need to have ability yo update micrometer, that can and will change API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeysenja1992 sergeysenja1992 sergeysenja1992 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@strekalovskiy @sergeysenja1992 @actions-user