add feature: add support in windows platform #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waruqi
reviewed
Nov 28, 2024
armgcc.lua
Outdated
| set_toolset("ar", "arm-none-eabi-ar") | ||
| set_toolset("as", "arm-none-eabi-gcc") | ||
| if is_plat("windows") then | ||
| set_toolset("cc", "arm-none-eabi-gcc.exe") |
waruqi
reviewed
Nov 28, 2024
armgcc.lua
Outdated
| set_toolset("ld", "arm-none-eabi-gcc") | ||
| set_toolset("ar", "arm-none-eabi-ar") | ||
| set_toolset("as", "arm-none-eabi-gcc") | ||
| if is_plat("windows") then |
There was a problem hiding this comment.
you should set toolset and call toolchain:is_plat in on_load.
on_load(function (toolchain)
if toolchain:is_plat("windows") then
toolchain:set("toolset", "cc", "...")
end
end)
waruqi
reviewed
Nov 28, 2024
armgcc.lua
Outdated
| -- io.writefile(gen_fi..".asm", asm) | ||
| os.execv("arm-none-eabi-objdump", {"-S", out}, {stdout=gen_fi..".asm"}) | ||
| os.exec("arm-none-eabi-objcopy -O ihex "..out.." "..gen_fi..".hex") | ||
| if is_plat("windows") then |
waruqi
reviewed
Nov 28, 2024
armgcc.lua
Outdated
| os.execv("arm-none-eabi-objdump", {"-S", out}, {stdout=gen_fi..".asm"}) | ||
| os.exec("arm-none-eabi-objcopy -O ihex "..out.." "..gen_fi..".hex") | ||
| if is_plat("windows") then | ||
| os.exec("arm-none-eabi-objcopy.exe -Obinary "..out.." "..gen_fi..".bin") |
waruqi
reviewed
Nov 28, 2024
armgcc.lua
Outdated
| -- os.exec("arm-none-eabi-objdump -S "..out.." > "..gen_fi..".asm") | ||
| -- local asm = os.iorun("arm-none-eabi-objdump -S build/cross/cortex-m4/release/minimal-proj") | ||
| -- io.writefile(gen_fi..".asm", asm) | ||
| os.execv("arm-none-eabi-objdump.exe", {"-S", out}, {stdout=gen_fi..".asm"}) |
|
Thank you, I will address the issues you've mentioned. |
waruqi
reviewed
Nov 28, 2024
arm-gcc.lua
Outdated
| -- os.exec("arm-none-eabi-objdump -S "..out.." > "..gen_fi..".asm") | ||
| -- local asm = os.iorun("arm-none-eabi-objdump -S build/cross/cortex-m4/release/minimal-proj") | ||
| -- io.writefile(gen_fi..".asm", asm) | ||
| if is_plat("windows") then |
waruqi
reviewed
Nov 28, 2024
.vscode/compile_commands.json
Outdated
| "directory": "d:\\project\\stm32-example-project", | ||
| "arguments": ["arm-none-eabi-gcc.exe", "-c", "-specs=nano.specs", "-mcpu=cortex-m4", "-mthumb", "-mfloat-abi=hard", "-mfpu=fpv4-sp-d16", "-fdata-sections", "-ffunction-sections", "-nostartfiles", "-Os", "-o", "build\\.objs\\minimal-proj\\cross\\cortex-m4\\release\\src\\startup.c.o", "src\\startup.c"], | ||
| "file": "src\\startup.c" | ||
| }] |
waruqi
reviewed
Nov 28, 2024
arm-gcc.lua
Outdated
| rule("generate-hex") | ||
| after_build(function(target) | ||
| print("$(env ARM_TOOL)") | ||
| print("after_build: generate hex files") |
waruqi
reviewed
Nov 28, 2024
waruqi
reviewed
Nov 28, 2024
waruqi
reviewed
Nov 28, 2024
|
|
||
| on_run(function() | ||
| print("Run binary in Qemu!") | ||
| local bin_out = os.files("$(buildir)/*.bin")[1] |
There was a problem hiding this comment.
use import("lib.detect.find_file") instead of os.files, and use core.project.config + config.buildir() instead of $(buildir)
waruqi
reviewed
Nov 28, 2024
| print("Run binary in Qemu!") | ||
| local bin_out = os.files("$(buildir)/*.bin")[1] | ||
| if bin_out then | ||
| os.exec("qemu-system-arm -M stm32-p103 -nographic -kernel " .. bin_out) |
waruqi
reviewed
Nov 28, 2024
| if bin_out then | ||
| os.exec("qemu-system-arm -M stm32-p103 -nographic -kernel " .. bin_out) | ||
| else | ||
| print("Do not find bin file in $(buildir)/") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I noticed that your project does not currently support the Windows platform, so I have created this pull request to address the issue. I hope it will be helpful to you. 😄