Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix copying lua/* to luadir #3

Merged
merged 9 commits into from
Nov 21, 2024
Merged

fix copying lua/* to luadir #3

merged 9 commits into from
Nov 21, 2024

Conversation

Freed-Wu
Copy link
Contributor

Fix #2

  • Before adding new features and new modules, please go to issues to submit the relevant feature description first.
  • Write good commit messages and use the same coding conventions as the rest of the project.
  • Please commit code to dev branch and we will merge into master branch in feature
  • Ensure your edited codes with four spaces instead of TAB.

  • 增加新特性和新模块之前,请先到issues提交相关特性说明,经过讨论评估确认后,再进行相应的代码提交,避免做无用工作。
  • 编写友好可读的提交信息,并使用与工程代码相同的代码规范,代码请用4个空格字符代替tab缩进。
  • 请提交代码到dev分支,如果通过,我们会在特定时间合并到master分支上。
  • 为了规范化提交日志的格式,commit消息,不要用中文,请用英文描述。

@waruqi waruqi changed the base branch from master to dev September 22, 2024 01:54
@waruqi
Copy link
Member

waruqi commented Sep 24, 2024

luarock install failed, but I don't know why.

@Freed-Wu
Copy link
Contributor Author

BTW, if rename src/xmake.lua to lua/luarocks/build/xmake.lua, the modules can be omitted from

build = {
    type = "builtin",
    modules = {
        ["luarocks.build.xmake"] = "src/xmake.lua"
    },
    copy_directories = {}
}

to

build = {
    type = "builtin",
}

@Freed-Wu
Copy link
Contributor Author

And seperate update *.yml to another PR may be clearer?

@Freed-Wu
Copy link
Contributor Author

Error: Failed cloning git repository.

Looks network failure?

@Freed-Wu
Copy link
Contributor Author

There are no any tag about example https://github.com/Freed-Wu/luarocks-build-xmake/blob/lua/rockspecs/example1-1.0-1.rockspec#L5

Whatever, the CI error is unrelated to this PR. I advise to open another issue to solve it.

@Freed-Wu
Copy link
Contributor Author

Any other problem?

@waruqi
Copy link
Member

waruqi commented Nov 20, 2024

Sorry, I forgot it, I will try fix ci in these days.

@waruqi waruqi closed this Nov 20, 2024
@waruqi waruqi reopened this Nov 20, 2024
@waruqi waruqi closed this Nov 20, 2024
@waruqi waruqi reopened this Nov 20, 2024
@waruqi waruqi closed this Nov 20, 2024
@waruqi waruqi reopened this Nov 20, 2024
@waruqi waruqi closed this Nov 20, 2024
@waruqi waruqi reopened this Nov 20, 2024
@waruqi waruqi closed this Nov 20, 2024
@waruqi waruqi reopened this Nov 20, 2024
@waruqi waruqi force-pushed the dev branch 2 times, most recently from 5cd2cba to d983935 Compare November 20, 2024 09:52
@waruqi waruqi closed this Nov 20, 2024
@waruqi waruqi reopened this Nov 20, 2024
@waruqi waruqi closed this Nov 20, 2024
@waruqi waruqi reopened this Nov 20, 2024
@waruqi waruqi force-pushed the dev branch 3 times, most recently from 912faf9 to ab64ed5 Compare November 20, 2024 11:00
@waruqi waruqi closed this Nov 21, 2024
@waruqi waruqi reopened this Nov 21, 2024
@waruqi waruqi force-pushed the dev branch 11 times, most recently from 6f4ec04 to 6ae9ef9 Compare November 21, 2024 06:29
@waruqi waruqi merged commit dd5a84c into xmake-io:dev Nov 21, 2024
13 checks passed
@waruqi
Copy link
Member

waruqi commented Nov 21, 2024

I have fixed it, but it need xmake dev version.

@Freed-Wu Freed-Wu deleted the lua branch November 21, 2024 10:17
@Freed-Wu
Copy link
Contributor Author

Can you publish a version after merge this PR in luarocks? 1.3-3 are still before this PR.

@waruqi
Copy link
Member

waruqi commented Nov 23, 2024

try 1.4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xmake backend will not copy lua code to lua directory ~/.local/share/lua
2 participants