Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes unwanted assertionFailure Core NavigateTo #1998

Merged
merged 5 commits into from
Mar 16, 2020
Merged

Removes unwanted assertionFailure Core NavigateTo #1998

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a9e0072
Merge pull request #1 from xmartlabs/master
adozenlines Dec 15, 2019
ec2adb4
Merge pull request #2 from xmartlabs/master
adozenlines Feb 14, 2020
9f332ff
Core.swift Navigation
adozenlines Mar 8, 2020
e1d24c2
Merge branch 'master' into master
adozenlines Mar 8, 2020
edfbc2e
Merge branch 'master' into master
adozenlines Mar 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/Core/Core.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1080,7 +1080,7 @@ extension FormViewController {

public func navigateTo(direction: Direction) {
guard let currentCell = tableView?.findFirstResponder()?.formCell() else { return }
guard let currentIndexPath = tableView?.indexPath(for: currentCell) else { assertionFailure(); return }
guard let currentIndexPath = tableView?.indexPath(for: currentCell) else { return }
guard let nextRow = nextRow(for: form[currentIndexPath], withDirection: direction) else { return }
if nextRow.baseCell.cellCanBecomeFirstResponder() {
tableView?.scrollToRow(at: nextRow.indexPath!, at: .none, animated: animateScroll)
Expand Down