Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chinese input issue #2150

Merged
merged 2 commits into from
Apr 12, 2021
Merged

Fix Chinese input issue #2150

merged 2 commits into from
Apr 12, 2021

Conversation

azone
Copy link
Contributor

@azone azone commented Mar 29, 2021

do nothing if the text field has markedTextRange

do nothing if the text field has markedTextRange
@mats-claassen
Copy link
Member

Please explain the issue, ideally with code to reproduce and state versions of Eureka, Xcode, iOS

@azone
Copy link
Contributor Author

azone commented Apr 12, 2021

If there is no marked text, the value of the property is nil. Marked text is provisionally inserted text that requires user confirmation; it occurs in multistage text input. The current selection, which can be a caret or an extended range, always occurs within the marked text. (https://developer.apple.com/documentation/uikit/uitextinput/1614489-markedtextrange)

You should not do anything during the marked text presents.

If you want to reproduce it, just run the demo, and do the following steps:

  1. input any Chinese characters and confirm the marked text
  2. input Chinese characters again

After those two steps, you'll found that you can't input anymore, or very weird.

@mats-claassen mats-claassen merged commit 9ba5cb5 into xmartlabs:master Apr 12, 2021
@mats-claassen mats-claassen mentioned this pull request Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants