Fix crash when user taps tab key on external keyboard #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source/Core/Core.swift
Outdated
| var didHandleEvent = false | ||
| for press in presses { | ||
| guard let key = press.key else { continue } | ||
| if key.keyCode == .keyboardTab, |
There was a problem hiding this comment.
Could add to existing or create another guard clause to avoid nesting.
Suggested change
| if key.keyCode == .keyboardTab, | |
| guard key.keyCode == .keyboardTab, key.modifiedFlags.contains(.command) else { continue } | |
| // Remaining code |
| @@ -11,9 +11,12 @@ jobs: | |||
| runs-on: macOS-latest | |||
| strategy: | |||
| matrix: | |||
| destination: ['platform=iOS Simulator,OS=14.4,name=iPhone 11'] | |||
| destination: ['platform=iOS Simulator,OS=15.2,name=iPhone 11'] | |||
There was a problem hiding this comment.
I assume this updates your framework to be built against iOS 15.2 and Xcode version 13.2.1?
There was a problem hiding this comment.
Yes, but just for the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2181