Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up chrysom client #147

Closed
kristinapathak opened this issue Mar 16, 2021 · 0 comments
Closed

Split up chrysom client #147

kristinapathak opened this issue Mar 16, 2021 · 0 comments
Assignees
Labels
feature new functionality proposal/implementation

Comments

@kristinapathak
Copy link
Contributor

We can split up the current chrysom client in order to separate the two main use cases of the current client: direct requests and polling. This will allow the code to be more modular, and I think it will aid in maintainability long term.

I'm proposing to have a BasicClient that provides the wrapper for http requests to argus, and then use that in a ListenerClient that uses a long running goroutine to poll argus for items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new functionality proposal/implementation
Projects
None yet
Development

No branches or pull requests

2 participants