initial chrysom split #206

mtrinh11 · 2021-10-14T19:25:47Z

Incomplete, pr'd to review thought process

kristinapathak

This looks great! I have some minor suggestions, mostly related to code organization.

chrysom/client.go

chrysom/client_test.go

chrysom/basicClient.go

chrysom/listenerClient.go

mtrinh11 · 2021-10-18T17:54:18Z

fixes #147

codecov · 2021-10-19T18:13:10Z

Codecov Report

Merging #206 (c68ac5c) into main (d23172a) will increase coverage by 0.35%.
The diff coverage is 87.69%.

❗ Current head c68ac5c differs from pull request most recent head 7a45577. Consider uploading reports for the commit 7a45577 to get more accurate results

@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
+ Coverage   62.66%   63.02%   +0.35%     
==========================================
  Files          16       17       +1     
  Lines        1074     1079       +5     
==========================================
+ Hits          673      680       +7     
+ Misses        384      378       -6     
- Partials       17       21       +4

Impacted Files	Coverage Δ
chrysom/store.go	`0.00% <0.00%> (-14.29%)`	⬇️
chrysom/listenerClient.go	`88.57% <88.57%> (ø)`
chrysom/basicClient.go	`86.66% <89.65%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d23172a...7a45577. Read the comment docs.