Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't change the identifier in the item saved to the store #65

Closed
j-mai opened this issue Oct 28, 2020 · 0 comments · Fixed by #68
Closed

Don't change the identifier in the item saved to the store #65

j-mai opened this issue Oct 28, 2020 · 0 comments · Fixed by #68
Labels
bug Something isn't working

Comments

@j-mai
Copy link
Contributor

j-mai commented Oct 28, 2020

Currently, when generating a key for a push request, the identifier that the client provides is overridden by the hashed key in this line:

item.Identifier = transformPushItemID(item.Identifier)

The user provided identifier should be saved as part of the resource. the push request object should probably include a Model.key as part of the struct instead. This way, when the user grabs all the resources or that specific resource, they can see the identifier they provided.

@j-mai j-mai added the bug Something isn't working label Oct 28, 2020
@j-mai j-mai mentioned this issue Oct 29, 2020
@joe94 joe94 closed this as completed in #68 Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant