Routes #68
Merged
Routes #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe94
suggested changes
Oct 30, 2020
| @@ -0,0 +1,16 @@ | |||
|
|
|||
There was a problem hiding this comment.
I don't think we want the docker-compose folder here
store/transport.go
Outdated
| return base64.RawURLEncoding.EncodeToString(checkSum[:]) | ||
| func generateID() string { | ||
| uuidWithHyphen := uuid.New() | ||
| return strings.Replace(uuidWithHyphen.String(), "-", "", -1) |
There was a problem hiding this comment.
We can keep the hyphens. They're URL safe and don't need encoding.
store/provide.go
Outdated
| @@ -58,7 +61,8 @@ func Provide(unmarshaller config.Unmarshaller, in StoreIn) StoreOut { | |||
| validateItemTTLConfig(&itemTTL) | |||
|
|
|||
| return StoreOut{ | |||
| SetItemHandler: newPushItemHandler(itemTTL, in.Store), | |||
| PushItemHandler: newPushItemHandler(itemTTL, in.Store), | |||
| SetItemHandler: newUpdateItemHandler(itemTTL, in.Store), | |||
There was a problem hiding this comment.
Might be a good idea to rename SetItemHandler to UpdateItemHandler` for consistency.
Codecov Report
@@ Coverage Diff @@
## main #68 +/- ##
==========================================
- Coverage 40.05% 39.54% -0.52%
==========================================
Files 15 15
Lines 739 789 +50
==========================================
+ Hits 296 312 +16
- Misses 427 461 +34
Partials 16 16
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
PUTcreation route to aPOSTPUTroute to update a specific resourceFixes #65